This is a log file detailing changes made to the OLPC theme to make it 
pass the crash test from the "GTK theme/engine torturer" and make it 
faster.


2006.07.11
==========

4:20 PM

First thing : wow, widget resizing is really, *really slow*. I need 
to work on integrating precise time measures to the torturer to have 
more objective values, but this should be an important concern soon. 

Second thing : the OLPC theme crashes on the very first (!) test made by 
the torturer. It seems like the NULL detail makes olpc_draw_box crash. 
Okay, let's fix this first.

Okay, in the whole source code, whenever we want to test if a 
particular detail is used, the current version always uses a strcmp: if 
detail is NULL, it segfaults.

Fixing the code by defining :

#define DETAIL(x) ((detail) && (!strcmp(x, detail)))

and calling if (DETAIL(schmurtz)) everywhere instead of all the current 
if (strcmp (...) == 0).

This macro assumes that the "detail" parameter will, indeed, always be 
named "detail", which seems reasonable.

Okay, that solves the problem. The engine passes the crash test (except 
the handle test that every engine crashes on) but, man, it takes *ages*. 
I mean, the crash test has been eating about 70% of my 2.8 GHz CPU for 
about 15 minutes, and it's not even finished, while simple themes or 
even Clearlooks are finished in less than 30 seconds: there is a major 
problem here. Next thing on the list will definitely be speed.